refactor: centralize pool active check into is_pool_active helper#453
Merged
Yunusabdul38 merged 4 commits intoWeb3Novalabs:mainfrom Mar 27, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the shola's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@CollinsC1O Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
@CollinsC1O fix ci error |
Yunusabdul38
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #386
Adds a private
is_pool_activehelper function to centralize the repeatedpool state check (
resolved == false && canceled == false && state == Active)that was scattered across
lib.rs.Changes
is_pool_active(pool: &Pool) -> boolhelper in the pure functions section oflib.rsplace_prediction,resolve_pool,cancel_pool,oracle_resolve, andincrease_max_total_stakewith calls to the helperNotes
Existing panic messages (
"Pool already resolved","Cannot place prediction on canceled pool")are preserved to avoid breaking existing tests. This is a pure refactor — no behavior changes.